6 Commits

6 changed files with 16 additions and 10 deletions

View File

@@ -10,6 +10,7 @@ import org.aspectj.lang.annotation.Pointcut;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
import com.example.demo.app.presentation.controller.pageproperty.SessionKeyword;
import com.example.demo.exception.NoSessionException; import com.example.demo.exception.NoSessionException;
@@ -32,7 +33,7 @@ public class SessionCheckAspect {
public void checkSession() { public void checkSession() {
HttpSession session = request.getSession(false); HttpSession session = request.getSession(false);
if (session == null || session.getAttribute("loginUser") == null) { if (session == null || session.getAttribute(SessionKeyword.LOGIN_USER) == null) {
throw new NoSessionException("不正なログインです"); throw new NoSessionException("不正なログインです");
} }

View File

@@ -12,6 +12,8 @@ import org.springframework.web.HttpRequestMethodNotSupportedException;
import org.springframework.web.bind.annotation.ControllerAdvice; import org.springframework.web.bind.annotation.ControllerAdvice;
import org.springframework.web.bind.annotation.ExceptionHandler; import org.springframework.web.bind.annotation.ExceptionHandler;
import com.example.demo.app.presentation.controller.pageproperty.PageReturnAttributeKeyword;
import com.example.demo.app.presentation.controller.pageproperty.TransitionTargetPageNameKeyword;
import com.example.demo.exception.NoSessionException; import com.example.demo.exception.NoSessionException;
@ControllerAdvice @ControllerAdvice
@@ -30,18 +32,18 @@ public class GlobalExceptionHandler {
LOGGER.log(Level.SEVERE, SEVERE_ERROR_MESSAGE_ILLEGAL_TRANSITION, e); LOGGER.log(Level.SEVERE, SEVERE_ERROR_MESSAGE_ILLEGAL_TRANSITION, e);
model.addAttribute( model.addAttribute(
"errorMessage", PageReturnAttributeKeyword.ERROR_MESSAGE,
"システムエラーが発生しました。" "システムエラーが発生しました。"
+ "初めからやり直してください。"); + "初めからやり直してください。");
return "redirect:/login"; return TransitionTargetPageNameKeyword.REDIRECT + TransitionTargetPageNameKeyword.LOGIN;
} }
@ExceptionHandler(HttpRequestMethodNotSupportedException.class) @ExceptionHandler(HttpRequestMethodNotSupportedException.class)
public String handleBadRequestException(Model model, Exception e, HttpSession session) { public String handleBadRequestException(Model model, Exception e, HttpSession session) {
model.addAttribute("error", SEVERE_ERROR_MESSAGE_BAD_REQUEST); model.addAttribute(PageReturnAttributeKeyword.ERROR, SEVERE_ERROR_MESSAGE_BAD_REQUEST);
model.addAttribute("status", HttpStatus.BAD_REQUEST.value()); model.addAttribute(PageReturnAttributeKeyword.STATUS, HttpStatus.BAD_REQUEST.value());
e.printStackTrace(); e.printStackTrace();
@@ -50,7 +52,7 @@ public class GlobalExceptionHandler {
System.out.println("session invalidated"); System.out.println("session invalidated");
session.invalidate(); session.invalidate();
return "error"; return TransitionTargetPageNameKeyword.ERROR_HTML;
} }
@ExceptionHandler(Exception.class) @ExceptionHandler(Exception.class)
@@ -60,6 +62,6 @@ public class GlobalExceptionHandler {
System.out.println("session invalidated exception"); System.out.println("session invalidated exception");
session.invalidate(); session.invalidate();
return "error"; return TransitionTargetPageNameKeyword.ERROR_HTML;
} }
} }

View File

@@ -25,6 +25,8 @@ public class LoginServiceImpl implements LoginService {
if (userEntity == null) { if (userEntity == null) {
return null; return null;
} else if (userEntity.getDeleteFlag() == 1) {
return null;
} }
boolean isValidPassword = false; boolean isValidPassword = false;

View File

@@ -275,7 +275,7 @@ public class GoalController {
int currentAmount = goalService.getCurrentAmount(userId); int currentAmount = goalService.getCurrentAmount(userId);
model.addAttribute("currentAmount", currentAmount); model.addAttribute(PageReturnAttributeKeyword.CURRENT_AMOUNT, currentAmount);
return TransitionTargetPageNameKeyword.GOAL_CREATE_HTML; return TransitionTargetPageNameKeyword.GOAL_CREATE_HTML;
} }

View File

@@ -4,7 +4,8 @@ public class PageReturnAttributeKeyword {
public static final String ERROR_MESSAGE = "errorMessage"; public static final String ERROR_MESSAGE = "errorMessage";
public static final String MESSAGE = "message"; public static final String MESSAGE = "message";
public static final String ERROR = "error";
public static final String STATUS = "status";
public static final String QUESTION_LIST = "questionList"; public static final String QUESTION_LIST = "questionList";
public static final String USER_FORM = "userForm"; public static final String USER_FORM = "userForm";

View File

@@ -124,7 +124,7 @@
if (tType == "0") { if (tType == "0") {
transactionType.value = 0; transactionType.value = 0;
} else { } else if (tType == "1") {
transactionType.value = 1; transactionType.value = 1;
} }